Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Message): update typings and remove propTypes #1254

Merged
merged 2 commits into from
Jan 31, 2017
Merged

Conversation

layershifter
Copy link
Member

This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.


Also, it converts Message to statefull components and update onDismiss behavior.

@codecov-io
Copy link

codecov-io commented Jan 30, 2017

Codecov Report

Merging #1254 into master will increase coverage by -0.01%.

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage    95.9%   95.89%   -0.01%     
==========================================
  Files         881      880       -1     
  Lines        4904     4899       -5     
==========================================
- Hits         4703     4698       -5     
  Misses        201      201
Impacted Files Coverage Δ
src/collections/Message/MessageContent.js 100% <ø> (ø)
src/collections/Message/MessageHeader.js 100% <100%> (ø)
src/collections/Message/Message.js 100% <100%> (ø)
src/collections/Message/MessageItem.js 100% <100%> (ø)
src/collections/Message/MessageList.js 100% <100%> (ø)
src/views/Statistic/Statistic.js 100% <ø> (ø)
src/views/Statistic/StatisticGroup.js 100% <ø> (ø)
src/elements/Button/ButtonGroup.js 100% <ø> (ø)
src/collections/Grid/GridRow.js 100% <ø> (ø)
src/views/Statistic/StatisticLabel.js 100% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5735515...7794674. Read the comment docs.

@levithomason
Copy link
Member

Perfect, thanks. I made one trivial update to the MessageItem description (added "list").

@levithomason levithomason merged commit a8f1088 into master Jan 31, 2017
@levithomason levithomason deleted the style/message branch January 31, 2017 01:09
@levithomason
Copy link
Member

Released in [email protected].

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
* style(Message): update typings and remove propTypes

* Update MessageItem.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants