fix(typings): inherit Radio props from Checkbox #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks correct to me. @layershifter any comments on this direction? I know you're heading up the TS refactor efforts. |
layershifter
approved these changes
Jan 31, 2017
There was a problem hiding this comment.
@levithomason Yes, it looks correct, seems I've missed my own TODO in #1155 😱
levithomason
changed the title
|
Thanks much fellas! |
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
fix(typings): inherit Radio props from Checkbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1155 the Radio component did not inherit the checkbox props. This might help with #1169