chore(package): Add ts-lint for typings #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.88% (diff: 100%)@@ master #1156 diff @@
==========================================
Files 879 879
Lines 4882 4882
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 4681 4681
Misses 201 201
Partials 0 0
|
levithomason
requested changes
Jan 16, 2017
| "tsd": "cpx './src/**/*.d.ts' dist/commonjs" | ||
| "tsd": "cpx './src/**/*.d.ts' dist/commonjs", | ||
| "tsd:lint": "tslint './src/**/*.d.ts'", | ||
| "tsd:lint:fix": "npm run tsd:lint -- --fix" |
There was a problem hiding this comment.
Let's silence the extra NPM error blocks this would produce on a failure:
-npm run tsd:lint -- --fix
+npm run -s tsd:lint -- --fix
added 3 commits
January 16, 2017 18:52
…antic-Org/Semantic-UI-React into chore/ts-lint # Conflicts: # src/collections/Menu/index.d.ts # src/elements/Input/index.d.ts
layershifter
commented
Jan 17, 2017
| @@ -47,7 +47,7 @@ export interface InputProps { | |||
| label?: any; | |||
|
|
|||
| /** A Label can appear outside an Input on the left or right. */ | |||
| labelPosition?: 'left', 'right', 'left corner', 'right corner'; | |||
| labelPosition?: 'left' | 'right' | 'left corner' | 'right corner'; | |||
There was a problem hiding this comment.
Fixed type definition.
layershifter
commented
Jan 17, 2017
| @@ -58,7 +58,7 @@ export interface InputProps { | |||
| * @param {SyntheticEvent} event - React's original SyntheticEvent. | |||
| * @param {object} data - All props and proposed value. | |||
| */ | |||
| onChange?: (e: React.SyntheticEvent<HTMLInputElement>, {...InputProps, value: string}) => void; | |||
| onChange?: (event: React.SyntheticEvent<HTMLInputElement>, data: onChangeData) => void; | |||
There was a problem hiding this comment.
Fixed type definition.
|
Rebased to |
levithomason
approved these changes
Jan 17, 2017
|
I just fixed the new conflicts after merging the other ts PRs. Will merge this on pass. |
|
I'll fix lint issues immediately. |
…React into chore/ts-lint # Conflicts: # src/elements/Container/index.d.ts # src/elements/Divider/index.d.ts # src/elements/Header/index.d.ts # src/elements/Icon/index.d.ts
|
I'll solve merge conflicts, too 😄 |
…React into chore/ts-lint # Conflicts: # src/elements/Flag/index.d.ts # src/elements/Image/index.d.ts # src/modules/Checkbox/index.d.ts
|
Okay, we can try to merge after tests pass 👍 |
|
Thanks much, will do. I'll make a release following as well. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working on #1155, I realized that the need to add linter for typings.
This PR adds
tslintfor its.