style(Search): several cleanups #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Jan 12, 2017
| @@ -34,6 +34,7 @@ interface SearchProps extends ReactMouseEvents<HTMLInputElement>, ReactFocusEven | |||
| /** Shorthand for Icon. */ | |||
| icon?: any; | |||
|
|
|||
| /** A search can show a loading indicator. */ | |||
There was a problem hiding this comment.
Added inline comment to prop.
There was a problem hiding this comment.
Thanks, we should also update the ts file comment as well.
layershifter
commented
Jan 12, 2017
| 'search', | ||
| className, |
There was a problem hiding this comment.
className is always last in our pattern.
layershifter
commented
Jan 12, 2017
| {menuContent} | ||
| </SearchResults> | ||
| ) | ||
| return <SearchResults className={resultsClasses}>{menuContent}</SearchResults> |
There was a problem hiding this comment.
This expression is too simple to be multiline.
layershifter
commented
Jan 12, 2017
| icon, | ||
| }) | ||
| ) | ||
| return Input.create(input, { |
There was a problem hiding this comment.
We don't really need parens there.
layershifter
commented
Jan 12, 2017
| @@ -169,17 +169,19 @@ export default class Search extends Component { | |||
| /** A search input can take up the width of its container. */ | |||
| input: customPropTypes.itemShorthand, | |||
|
|
|||
| size: PropTypes.oneOf(_meta.props.size), | |||
|
|
|||
| /** A search can show a loading indicator. */ | |||
There was a problem hiding this comment.
Let's also update the ts file.
layershifter
commented
Jan 12, 2017
| loading: PropTypes.bool, | ||
|
|
||
| /** A search can have different sizes. */ |
47 tasks
style(Search): propTypes cleanups, update comments
layershifter
force-pushed
the
styte/search
branch
from
8f862ad
to
c3c6e65
Compare
|
I've updated ts-definition file and updated propTypes for #524. |
Current coverage is 95.88% (diff: 100%)
|
|
Thanks much! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed the moment when #1123 was merged, so I'll make several style cleanups in this PR.
This PR: