Feature/header component #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| render() { | ||
| return ( | ||
| <div> | ||
| TODO: explain semantic uses divs and h* tags and how we accomplish that with Header and HEader.H* |
There was a problem hiding this comment.
We should do this before merging.
| </div> | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Component for the .Subheader addition. Returns a <div class="sub header"> and can take additional classNames, although I'm not sure if Semantic has any others for the subheader
There was a problem hiding this comment.
Your comment is missing some content. Though, the code seems correct to me.
There was a problem hiding this comment.
Oh, actually, it needs to spread props. See _Header.js for a reference on how to use getUnhandledProps() to spread additional props.
There was a problem hiding this comment.
Yeah, I was missing a backtick 🙁
kyleturco
force-pushed
the
feature/header-component
branch
from
9c7ab3e
to
9fa9db5
Compare
|
🉑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107