Feature/list examples #100
Conversation
| </List> | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Only did one example for the basic list - Semantic has a handful, would adding some variations be useful or necessary?
There was a problem hiding this comment.
I see what you mean. It looks like they just show a mashup of various lists at the top, then dive into each specific capability. I think we're good with the basics up top if we have links/icons/etc down below.
| description='This text will always have a left margin so it sits alongside the icon' | ||
| /> | ||
| <ListItem | ||
| image={triangleIcon} |
There was a problem hiding this comment.
Use icon props here, I won't comment on further icon/image props.
levithomason
force-pushed
the
feature/list-examples
branch
from
04d55e2
to
065dd73
Compare
|
Since I rebased this guy and updated it, would you check it out and make sure it still looks sane. If so, it is good to merge! 🉑 |
| <div className={classes}> | ||
| <img {...this.props} /> | ||
| </div> | ||
| <img {...this.props} className={classes} /> |
There was a problem hiding this comment.
since you are returning this one element, the parentheses are not necessary and you can move the image up to line 26.
There was a problem hiding this comment.
Nice catch, will update and merge.
|
1 question, 1 comment, overall good to merge!! 🐙 |
No description provided.