Dimmer - Inactive dimmer still overlays segment contents, making them unclickable

[ben174]

Steps

1. Create a Segment with a Dimmer, Loader, and Button

      <Segment>
        <Dimmer active={false} inverted>
          <Loader />
        </Dimmer>
        <Button>Test</Button>
      </Segment>

2. Click the button

Expected Result

Button should be clickable. Cursor should be pointer.

Actual Result

Button is unclickable. Inspecting the DOM shows that the dimmer node is still present, preventing clicks from items behind it.

Version

0.58.1

Testcase

http://codepen.io/ben174/pen/pEMYVG

[levithomason]

Confirmed. We should be adding the disabled class when !active. This class reduces the size to 0x0 pixels:

[ben174]

Yea, I just figured out the same. Was just forking the repo and can create
a PR shortly if you haven't already fixed it.

On Tue, Nov 1, 2016 at 4:28 PM, Levi Thomason [email protected]
wrote:

Confirmed. We should be adding the disabled class when !active. This
class reduces the size to 0x0 pixels:

[image: image]
https://cloud.githubusercontent.com/assets/5067638/19911330/2975b9e2-a050-11e6-81b2-320a5c3714f9.png

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#780 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABbtE1LrDlY589pGoTLMVSs1FWzf67iPks5q58sqgaJpZM4Kmss7
.

[levithomason]

No sir, I haven't. A PR would be of great help.

[ben174]

Awesome, will do thanks!