feat(Table.HeaderCell): sorted={false} is now supported to simplify y…

…our JSX logic
Semantic-Org · Jun 5, 2017 · 6a690e0 · 6a690e0
1 parent 100c246
commit 6a690e0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/src/collections/Table/TableHeaderCell.d.ts b/src/collections/Table/TableHeaderCell.d.ts
@@ -10,8 +10,11 @@ export interface TableHeaderCellProps extends TableCellProps {
   /** Additional classes. */
   className?: string;
 
-  /** A header cell can be sorted in ascending or descending order. */
-  sorted?: 'ascending' | 'descending';
+  /**
+   * A header cell can be sorted in ascending or descending order, but we also
+   * allow the literal `false`
+  */
+  sorted?: 'ascending' | 'descending' | false;
 }
 
 declare const TableHeaderCell: React.StatelessComponent<TableHeaderCellProps>;

diff --git a/src/collections/Table/TableHeaderCell.js b/src/collections/Table/TableHeaderCell.js
@@ -37,8 +37,11 @@ TableHeaderCell.propTypes = {
   /** Additional classes. */
   className: PropTypes.string,
 
-  /** A header cell can be sorted in ascending or descending order. */
-  sorted: PropTypes.oneOf(['ascending', 'descending']),
+  /**
+   * A header cell can be sorted in ascending or descending order, but we also
+   * allow the literal `false`
+  */
+  sorted: PropTypes.oneOf(['ascending', 'descending', false]),
 }
 
 TableHeaderCell.defaultProps = {

diff --git a/test/specs/collections/Table/TableHeaderCell-test.js b/test/specs/collections/Table/TableHeaderCell-test.js
@@ -5,7 +5,7 @@ import TableHeaderCell from 'src/collections/Table/TableHeaderCell'
 
 describe('TableHeaderCell', () => {
   common.isConformant(TableHeaderCell)
-  common.propKeyAndValueToClassName(TableHeaderCell, 'sorted', ['ascending', 'descending'])
+  common.propKeyAndValueToClassName(TableHeaderCell, 'sorted', ['ascending', 'descending', false])
 
   it('renders as a th by default', () => {
     shallow(<TableHeaderCell />)