refactor(jquery): remove all traces of jquery

Semantic-Org · Aug 21, 2016 · 06380b2 · 06380b2
1 parent b2e3d68
commit 06380b2
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 90 deletions.
diff --git a/README.md b/README.md
@@ -104,18 +104,19 @@ Once you change the flag, you need to refresh your browser to see the changes in
 
 ## How Can I Help?
 
-Our [CONTRIBUTING.md][1] is a step-by-step setup and development guide. It is meant to be read from top to bottom.  Once you're up to speed, we have two areas of focus:
+Our [CONTRIBUTING.md][1] is a step-by-step setup and development guide. It is meant to be read from top to bottom.  Once you're up to speed, each issue here includes more information on how you can help:
 
-### v1.0 Migrations
+### [v1.0 Migrations][15]
 
-Each issue includes more information on how you can help:
+Have a look at the task list on the issue to see where you can jump in.
 
-1. [Moving legacy component APIs to our v1 API][15]
-1. [Removing jQuery and SUI JS][11]
+### [Missing Components][17]
 
-### New Components
+We're seeking component parity with Semantic UI, plus some addons.  There is an issue for every missing component, labeled `enhancement` `help wanted`.  Just comment on the issue you'd like to take.
 
-We're seeking component parity with Semantic UI, plus some addons.  There is an issue for every missing component, labeled [`enhancement` `help wanted`][17].
+### [Help Wanted Label][4]
+
+Any other issue labeled `help wanted` is ready for a PR.
 
 ## Our Principles
 
@@ -168,7 +169,7 @@ Made with :heart: [@TechnologyAdvice][9], a ridiculous [place to work][16].
 [1]: https://github.com/TechnologyAdvice/stardust/blob/master/CONTRIBUTING.md
 [2]: https://technologyadvice.github.io/stardust/
 [3]: https://facebook.github.io/react/
-[4]: #
+[4]: https://github.com/TechnologyAdvice/stardust/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted
 [5]: http://semantic-ui.com/
 [6]: https://github.com/TechnologyAdvice/stardust/milestone/1
 [7]: https://github.com/webpack/webpack-dev-server/

diff --git a/karma.conf.js b/karma.conf.js
@@ -1,10 +1,7 @@
 const { argv } = require('yargs')
 const config = require('./config')
-const webpack = require('webpack')
 const webpackConfig = require('./webpack.config')
 
-const { paths } = config
-
 module.exports = (karmaConfig) => {
   karmaConfig.set({
     basePath: process.cwd(),
@@ -51,16 +48,9 @@ module.exports = (karmaConfig) => {
           ...webpackConfig.module.loaders,
         ],
       }),
-      plugins: [
-        ...webpackConfig.plugins,
-        // utils/jquery loads real jQuery and semantic-ui-css
-        // we alias jquery and semantic-ui-css to mocks during tests
-        // ignore this module so we can use the mock versions in alias below
-        new webpack.NormalModuleReplacementPlugin(/lib\/jquery/, 'empty'),
-      ],
+      plugins: webpackConfig.plugins,
       resolve: Object.assign({}, webpackConfig.resolve, {
         alias: Object.assign({}, webpackConfig.resolve.alias, {
-          jquery: `${paths.test('mocks')}/SemanticjQuery-mock.js`,
           sinon: 'sinon/pkg/sinon',
           // These are internal deps specific to React 0.13 required() by enzyme
           // They shouldn't be requiring these at all, issues and fix proposed

diff --git a/package.json b/package.json
@@ -50,7 +50,6 @@
   "dependencies": {
     "classnames": "^2.1.5",
     "debug": "^2.2.0",
-    "jquery": "^3.1.0",
     "lodash": "^4.6.1",
     "react-portal": "^2.2.1",
     "semantic-ui-css": "^2.2.2"

diff --git a/src/index.js b/src/index.js
@@ -1,5 +1,3 @@
-import './lib/jquery'
-
 export * from './addons'
 export * from './collections'
 export * from './elements'

diff --git a/src/lib/jquery.js b/src/lib/jquery.js
diff --git a/src/modules/Dropdown/Dropdown.js b/src/modules/Dropdown/Dropdown.js
@@ -703,8 +703,6 @@ export default class Dropdown extends Component {
     return <div className={classes}>{_text}</div>
   }
 
-  // TODO hidden input only exists for backwards compatibility with SUI jQuery plugins
-  // remove once those are removed
   renderHiddenInput = () => {
     debug('renderHiddenInput()')
     const { value } = this.state

diff --git a/test/mocks/SemanticjQuery-mock.js b/test/mocks/SemanticjQuery-mock.js
diff --git a/test/mocks/jQueryLoader-mock.js b/test/mocks/jQueryLoader-mock.js
diff --git a/webpack.config.js b/webpack.config.js
@@ -81,7 +81,6 @@ webpackConfig.plugins = [
     versions: {
       sui: require('semantic-ui-css/package.json').version,
       faker: require('faker/package.json').version,
-      jquery: require('jquery/package.json').version,
       lodash: require('lodash/package.json').version,
     },
   }),