Servicenow/v1 #97
Merged
Servicenow/v1 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions/servicenow/actions.py
Outdated
| Returns: | ||
| A structure representing the incidents. | ||
| """ | ||
| today = datetime.today() |
There was a problem hiding this comment.
Shouldn't this be just day, month and year so that current time is not used as filter which would exclude all incidents created earlier that day ?
mikahanninen
approved these changes
Nov 18, 2024
vlad-sema4
force-pushed
the
servicenow/v1
branch
from
a1b8468
to
d57e907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new action package for Service Now
How can (was) this tested?
Tested in Sema4ai Studio
Checklist: