Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moonpay payment screens and flow #2548

Merged
merged 6 commits into from
Feb 12, 2021
Merged

Conversation

andregoncalves
Copy link
Collaborator

No description provided.

@andregoncalves andregoncalves self-assigned this Feb 11, 2021
@coveralls
Copy link

coveralls commented Feb 11, 2021

Pull Request Test Coverage Report for Build 18901

  • 50 of 235 (21.28%) changed or added relevant lines in 6 files are covered.
  • 97 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-2.0%) to 40.561%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/common/moonpay/index.js 4 7 57.14%
src/main/moonpay/moonpay-api.js 11 15 73.33%
src/common/navigation/flow.js 1 6 16.67%
src/common/moonpay/auth.js 1 10 10.0%
src/main/moonpay/moonpay-service.js 0 46 0.0%
src/common/moonpay/payment.js 33 151 21.85%
Files with Coverage Reduction New Missed Lines %
src/common/kyc/fixtures/templates.js 1 0%
src/common/moonpay/auth.js 2 11.44%
src/common/identity/selectors.js 5 33.26%
src/common/kyc/index.js 89 7.94%
Totals Coverage Status
Change from base Build 18880: -2.0%
Covered Lines: 3904
Relevant Lines: 8757

💛 - Coveralls

Copy link
Contributor

@maycon-mello maycon-mello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -474,7 +481,8 @@ const submitKycDocumentsOperation = ops => () => async (dispatch, getState) => {
await dispatch(ops.setKYCSubmitted(true));
} catch (error) {
log.error(error);
await dispatch(ops.setKycError(error.message));
// await dispatch(ops.setKycError(error.response.body.message));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we remove this line?

const currencies = useSelector(moonPaySelectors.getSupportedFiat);
const currencyCode = config.dev ? 'ETH' : 'KEY';

// console.log('quote', quote);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we can remove these consoles as well

@andregoncalves andregoncalves merged commit a39d195 into dev Feb 12, 2021
@andregoncalves andregoncalves deleted the feat-moonpay-payment branch February 12, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants