Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chrome-browser-woes #1853

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Create chrome-browser-woes #1853

merged 8 commits into from
Aug 19, 2024

Conversation

skyhirider
Copy link
Contributor

@skyhirider skyhirider commented Aug 11, 2024

User description

Creating this pull request based on feedback from SeleniumHQ/selenium#14342

Feel free to make suggestions to the blog post.


PR Type

documentation


Description

  • Added a new blog post titled "Two Chrome browser woes that might affect you".
  • Discussed the issue of Chrome asking for search engine selection every time it is launched during automation.
  • Provided a solution to bypass the search engine selection screen using --disable-search-engine-choice-screen.
  • Discussed the issue of Chrome downloading language plugins and wasting bandwidth.
  • Provided a solution to disable language plugin downloads using --disable-features=OptimizationGuideModelDownloading,OptimizationHintsFetching,OptimizationTargetPrediction,OptimizationHints.

Changes walkthrough 📝

Relevant files
Documentation
chrome-browser-woes
Added blog post on Chrome browser issues and solutions     

website_and_docs/content/blog/2024/chrome-browser-woes

  • Added a new blog post discussing two issues with Chrome browser.
  • Provided solutions to bypass the search engine selection screen.
  • Provided solutions to prevent Chrome from downloading language
    plugins.
  • +25/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Aug 11, 2024

    Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit f0a0bf7
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/66c31a02e228ca00087a98ef
    😎 Deploy Preview https://deploy-preview-1853--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @codiumai-pr-agent-pro codiumai-pr-agent-pro bot added the documentation Improvements or additions to documentation label Aug 11, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    codiumai-pr-agent-pro bot commented Aug 11, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    ✅ Improve clarity and correct typos in section headers
    Suggestion Impact:The typo in the section header was corrected, improving clarity, although the exact suggested title was not used.

    code diff:

    -# Search engine selections creen
    +## Search engine selection screen

    Consider using a more descriptive and accurate title for the section header. The
    current header "Search engine selections creen" seems to have a typo and might be
    unclear to readers. A clearer header could be "Handling Chrome's Search Engine
    Selection Screen".

    website_and_docs/content/blog/2024/chrome-browser-woes [3]

    -# Search engine selections creen
    +# Handling Chrome's Search Engine Selection Screen
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion corrects a typo and makes the header more descriptive, which significantly improves readability and clarity.

    9
    ✅ Correct typos and improve the tone of section headers
    Suggestion Impact:The typo "you" was corrected to "your" and the phrase was rephrased from "wastes" to "consumes" in the section header.

    code diff:

    -# Chrome wastes over 60MB of you bandwidth downloading language plugins

    The phrase "Chrome wastes over 60MB of you bandwidth" contains a typo and could be
    rephrased for better clarity and professionalism. Consider revising it to "Chrome
    consumes over 60MB of your bandwidth".

    website_and_docs/content/blog/2024/chrome-browser-woes [15]

    -# Chrome wastes over 60MB of you bandwidth downloading language plugins
    +# Chrome consumes over 60MB of your bandwidth downloading language plugins
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion corrects a typo and rephrases the header for better clarity and professionalism, which is important for maintaining the document's quality.

    9
    Add explanations for technical terms to aid reader understanding

    To improve the technical accuracy and clarity, consider explaining briefly what the
    .crx files are. This addition can help readers who are not familiar with Chrome's
    architecture or file types.

    website_and_docs/content/blog/2024/chrome-browser-woes [17]

    -Every time you launch Chrome, [it will query and download several .crx files](https://www.reddit.com/r/chrome/comments/u78vd0/chrome_has_constantly_been_downloading_something/).
    +Every time you launch Chrome, it queries and downloads several .crx files, which are Chrome extension files, [as noted here](https://www.reddit.com/r/chrome/comments/u78vd0/chrome_has_constantly_been_downloading_something/).
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Adding an explanation for .crx files improves the technical accuracy and helps readers who may not be familiar with Chrome's architecture, enhancing the document's educational value.

    8
    Maintainability
    Use bullet lists for browser arguments to enhance document readability

    To enhance readability and maintain a consistent format, consider using a bullet
    list to present the browser arguments. This format helps in distinguishing between
    different configurations and improves the visual appeal of the document.

    website_and_docs/content/blog/2024/chrome-browser-woes [9-13]

    -To bypass this, use the argument below when specifying the browser options.
    +To bypass this, use the following argument when specifying the browser options:
    +- `--disable-search-engine-choice-screen`
     
    -```
    ---disable-search-engine-choice-screen
    -```
    -
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Using a bullet list for the browser arguments improves readability and maintains a consistent format, though it is a minor enhancement.

    7

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    HI @skyhirider,

    Thanks for the informative blog!

    However, it seems a bit incomplete and is missing titles and tags. Could you please update it with these details?

    I’ve provided a sample below for reference, but feel free to rewrite it in your own style.
    https://gist.github.com/harsha509/7850feaceeeead02af0ed47a8579dbc1

    Thanks,
    Sri

    website_and_docs/content/blog/2024/chrome-browser-woes Outdated Show resolved Hide resolved
    @skyhirider
    Copy link
    Contributor Author

    @harsha509 thanks for the suggestion, updated the article. Let me know if more changes are needed.

    website_and_docs/content/blog/2024/chrome-browser-woes Outdated Show resolved Hide resolved
    website_and_docs/content/blog/2024/chrome-browser-woes Outdated Show resolved Hide resolved
    @skyhirider
    Copy link
    Contributor Author

    Thanks for pointing out the typos, missed them when re-reading. Fixed.

    Copy link
    Member

    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you, @skyhirider!

    @diemol diemol dismissed harsha509’s stale review August 19, 2024 10:11

    Changes implemented

    @diemol diemol merged commit 3260452 into SeleniumHQ:trunk Aug 19, 2024
    6 checks passed
    selenium-ci added a commit that referenced this pull request Aug 19, 2024
    * Create chrome-browser-woes
    
    * Update website_and_docs/content/blog/2024/chrome-browser-woes
    
    Co-authored-by: Sri Harsha <[email protected]>
    
    * add article tags, reformat text
    
    * Update website_and_docs/content/blog/2024/chrome-browser-woes
    
    Co-authored-by: Sri Harsha <[email protected]>
    
    * Update website_and_docs/content/blog/2024/chrome-browser-woes
    
    Co-authored-by: Sri Harsha <[email protected]>
    
    * Fixing file name and format issues
    
    ---------
    
    Co-authored-by: Sri Harsha <[email protected]>
    Co-authored-by: Diego Molina <[email protected]>
    
    [deploy site] 3260452
    @skyhirider skyhirider deleted the patch-1 branch August 19, 2024 12:06
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants