Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in comment #850

Closed
wants to merge 1 commit into from
Closed

typo in comment #850

wants to merge 1 commit into from

Conversation

gotcha
Copy link
Contributor

@gotcha gotcha commented Jul 30, 2015

No description provided.

@ddavison
Copy link
Member

have you signed the CLA?

@gotcha
Copy link
Contributor Author

gotcha commented Jul 30, 2015

Nope, I suggest you fix the typo yourself.

@ddavison ddavison closed this in 6ccaf7f Jul 30, 2015
@ddavison
Copy link
Member

not sure why you'd trouble yourself with a PR if you just wanted us to do it, but whatever. done. thanks.

@gotcha
Copy link
Contributor Author

gotcha commented Jul 30, 2015

To allow you to accept the fix with a single click. I did not know there was the CLA.
Github makes all the work of a PR for me.

@ddavison
Copy link
Member

when you create a pull request, there is a link at the top that says "please abide by the CONTRIBUTING guidelines" :) it is step 6 to sign the contributor license agreement.

We ask this so that we know that contributors have the right to donate the code.

also it will put you as an official contributor to the source code.

No worries though, it's in. If you want to create a future pull request, feel free. just make sure to read the contribution guidelines :) (CONTRIBUTING.md)

@gotcha
Copy link
Contributor Author

gotcha commented Jul 30, 2015

I have now signed the CLA. However, there should be a balance between formality and openness. It is in the interest of everyone to keep barrier to contribute fix to typos as low as possible.

@ddavison
Copy link
Member

agreed.. I don't believe there's a contributor here that doesn't agree with that statement. I think we also all agree that is super annoying and a pain to not just click the "Merge" button, but we need to sign-off of every commit per rules set by the software freedom conservancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants