Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setPermission to JavaScript bindings #8493

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

devoto13
Copy link
Contributor

@devoto13 devoto13 commented Jul 9, 2020

Description

Same as 2260d41, but for JavaScript.

I'm not sure if I should update the documentation for this somewhere. Please point me out if need to.

Motivation and Context

See linked commit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2020

CLA assistant check
All committers have signed the CLA.

@AutomatedTester
Copy link
Member

thanks for your contribution

@AutomatedTester AutomatedTester merged commit df045c8 into SeleniumHQ:trunk Jul 9, 2020
@devoto13 devoto13 deleted the set-permission-js branch July 10, 2020 05:34
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants