-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send W3C capabilities in the new session request. #4974
Conversation
This probably also applies to Grid, but I'm really not that familiar with Grid so I'm not positive. Other language bindings do fancier things like filtering non-W3C capability names out of the W3C capabilities blob (here it is in Python). Not sure how necessary you feel that is. Also kinda undecided how to treat required capabilities, but those should go away at some point anyway, so maybe you were already planning an API change to eliminate them. |
If the Selenium standalone server only finds legacy capabilities in the request, then it will assume that the client doesn't speak W3C, and will return a legacy response. Sending a request that includes the W3C keys induces it to send a W3C response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the tests pass with this change? Last time I tried there were a lot of failures still.
@@ -380,7 +380,7 @@ function normalizeProxyConfiguration(config) { | |||
} | |||
} else if ('pac' === config.proxyType) { | |||
if (config.proxyAutoconfigUrl && !config.pacUrl) { | |||
config.pacUrl = config.proxyAutoconfigUrl; | |||
config.proxyAutoconfigUrl = config.proxyAutoconfigUrl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it looks like the entire normalizeProxyConfiguration
function isn't needed anymore
I do have some code (probably living in the wrong file right now) that will filter non-W3C capability names like some of the other language bindings do. But if you're planning to completely ditch legacy protocol support anyway, then maybe there's no need for any of this -- once all the capability names are changed, you could just switch completely to W3C capabilities instead of sending this hybrid. (I'm going to backport some version of this to our internal 3.6.0 branch in order to continue to support Chrome users, though.) |
I added that commit that drops invalid capabilities, if you're curious. The |
If the Selenium standalone server only finds legacy capabilities in the request,
then it will assume that the client doesn't speak W3C, and will return a legacy
response. Sending a request that includes the W3C keys induces it to send a W3C
response.
X
in the preceding checkbox, I verify that I have signed the Contributor License Agreement