Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type errors for input_device and file_detector #14459

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

Delta456
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR for type errors for input_device.py and file_detector.py as seen in https://github.com/SeleniumHQ/selenium/actions/runs/10626264126/job/29457778562

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@Delta456 Delta456 marked this pull request as ready for review August 31, 2024 16:53
@pujagani pujagani added the python Pull requests that update Python code label Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.68%. Comparing base (8fc4299) to head (d87ba2c).
Report is 1 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #14459      +/-   ##
==========================================
+ Coverage   57.65%   57.68%   +0.02%     
==========================================
  Files          89       89              
  Lines        5571     5579       +8     
  Branches      236      240       +4     
==========================================
+ Hits         3212     3218       +6     
+ Misses       2123     2121       -2     
- Partials      236      240       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Delta456 !

@harsha509 harsha509 merged commit 49f2f76 into SeleniumHQ:trunk Sep 10, 2024
13 checks passed
@harsha509
Copy link
Member

Congratulations on your first contribution to Selenium @Delta456 🎉 🎉 🎉 !

@Delta456 Delta456 deleted the mypy_fix branch September 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants