-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] change source of navigation alias #13960
Conversation
…he other way around
PR Description updated to latest commit (2ddc605)
|
PR Review 🔍
|
PR Code Suggestions ✨
|
CI Failure Feedback 🧐
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
[dotnet] have url property setter call navigation method instead of the other way around
User description
Description
Put the navigation command execution in the navigation class and have the driver property call the method instead of the other way around
Motivation and Context
Useful for when updating to async since properties can't be executed async; Shouldn't have any side effects
Note: need to check null in both overloaded methods because calling
ToString()
on a null gives an exceptionPR Type
enhancement
Description
WebDriver
andNavigator
classes to improve code structure and future maintenance.Navigator.cs
, added robust null checking and parameter setup for URL navigation, ensuring better error handling.WebDriver.cs
, simplified URL property by delegating URL setting to theNavigator
class, enhancing code readability and reuse.Changes walkthrough 📝
Navigator.cs
Enhance URL Navigation Handling in Navigator Class
dotnet/src/webdriver/Navigator.cs
GoToUrl(string
url)
.navigation.
GoToUrl(string url)
.WebDriver.cs
Refactor WebDriver URL Property to Use Navigator
dotnet/src/webdriver/WebDriver.cs
logic.