Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet][rb][java][js][py] Automated Browser Version Update #13916

Merged
merged 1 commit into from
May 8, 2024

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented May 8, 2024

User description

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed


PR Type

Enhancement


Description

  • Updated the URLs and SHA256 checksums for both Chrome and ChromeDriver on Linux and Mac platforms.
  • The updates ensure compatibility with the latest browser and driver versions, enhancing testing reliability.

Changes walkthrough 📝

Relevant files
Enhancement
repositories.bzl
Update Chrome and ChromeDriver versions for Linux and Mac

common/repositories.bzl

  • Updated URL and SHA256 for Linux Chrome to version 124.0.6367.155
  • Updated URL and SHA256 for Mac Chrome to version 124.0.6367.155
  • Updated URL and SHA256 for Linux ChromeDriver to version
    124.0.6367.155
  • Updated URL and SHA256 for Mac ChromeDriver to version 124.0.6367.155
  • +8/-8     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    PR Description updated to latest commit (1d2bd9b)

    Copy link
    Contributor

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are straightforward, involving only updates to URLs and SHA256 checksums for browser and driver versions. The structure and logic of the code remain unchanged, making it easier to review.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Incorrect Checksums: If the SHA256 checksums are not correctly matched with the downloaded files, it could lead to build failures or security risks if tampered files are used.

    🔒 Security concerns

    No

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestions                                                                                                                                                       
    Maintainability
    Use a variable for common URL prefixes to simplify future updates and reduce errors.

    Consider using a variable for the common URL prefix to improve maintainability and reduce
    the risk of typos when updating URLs in the future.

    common/repositories.bzl [202]

    -url = "https://storage.googleapis.com/chrome-for-testing-public/124.0.6367.155/linux64/chrome-linux64.zip"
    +CHROME_BASE_URL = "https://storage.googleapis.com/chrome-for-testing-public/"
    +url = CHROME_BASE_URL + "124.0.6367.155/linux64/chrome-linux64.zip"
     
    Best practice
    Ensure consistent use of the strip_prefix attribute across similar archive configurations.

    Ensure that the strip_prefix attribute is consistently used or documented if its omission
    is intentional for certain archives.

    common/repositories.bzl [201-204]

     http_archive(
         name = "linux_chrome",
         url = "https://storage.googleapis.com/chrome-for-testing-public/124.0.6367.155/linux64/chrome-linux64.zip",
         sha256 = "0761489e320bb56a29f53c051abea0a26418afcef62af2fa9bf1d4768a78d005",
    +    strip_prefix = "chrome-linux64",
         build_file_content = """
     
    Regularly update dependencies to maintain compatibility and security.

    Regularly review and update the dependencies to ensure compatibility and security with the
    latest versions.

    common/repositories.bzl [224]

    +# Ensure dependencies are up-to-date
     url = "https://storage.googleapis.com/chrome-for-testing-public/124.0.6367.155/mac-x64/chrome-mac-x64.zip"
     
    Security
    Verify SHA256 checksums against a trusted source to enhance security.

    Verify the integrity and source of the SHA256 checksums to prevent potential security
    risks from compromised binaries.

    common/repositories.bzl [203]

    +# Ensure SHA256 checksums are verified against a trusted source
     sha256 = "0761489e320bb56a29f53c051abea0a26418afcef62af2fa9bf1d4768a78d005"
     
    Enhancement
    Automate the update process for URLs and SHA256 checksums to reduce manual maintenance.

    Consider automating the update of URLs and SHA256 checksums to reduce manual errors and
    improve efficiency.

    common/repositories.bzl [202-203]

    -url = "https://storage.googleapis.com/chrome-for-testing-public/124.0.6367.155/linux64/chrome-linux64.zip"
    -sha256 = "0761489e320bb56a29f53c051abea0a26418afcef62af2fa9bf1d4768a78d005"
    +# Automated script to update URL and SHA256
    +url, sha256 = get_latest_chrome_version("linux64")
     

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants