Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Correct ChromiumDriverService.AllowedIPAddresses property name #13626

Merged

Conversation

YevgeniyShunevych
Copy link
Contributor

@YevgeniyShunevych YevgeniyShunevych commented Feb 24, 2024

Description

This is a correction of commit e7fb98b made in v4.18. If you check that commit changes, you should see that the old property WhitelistedIPAddresses actually was renamed, I believe accidentally, to WhitelistedIpAddresses marked with [Obsolete] attribute. IP -> Ip. So it turned to a breaking change that was not intended to be. So I renamed that old property back. Additionally, actual new AllowedIpAddresses property doesn't follow C# naming convention with Ip. So I corrected it to have IP as well.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol force-pushed the correct-chrome-allowed-ip-addresses branch from 7e1ac2b to d1af3dd Compare February 26, 2024 19:58
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @YevgeniyShunevych!

@diemol diemol merged commit da62a40 into SeleniumHQ:trunk Feb 26, 2024
11 checks passed
@YevgeniyShunevych
Copy link
Contributor Author

No problem, @diemol. I think maybe you can even consider releasing this as v4.18.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants