Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bidi][js] Add "addintercept" and "removeintercept" commands #13564

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Feb 8, 2024

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add commands that are the foundation for Networkwork interceptor implementation in BiDi. https://w3c.github.io/webdriver-bidi/#module-network-commands

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani added C-nodejs C-devtools BiDi or Chrome DevTools related issues labels Feb 8, 2024
@pujagani pujagani merged commit e815a1c into SeleniumHQ:trunk Feb 8, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-devtools BiDi or Chrome DevTools related issues C-nodejs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant