Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] move copyright from rake task to a bazel target #13512

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Jan 25, 2024

Status

Rebased off latest, and relies on #13514 now to show off that it can auto correct copyright as well.
So wait for 13514 to merge before merging this.

What #13514 looks like needs to be discussed more. This PR is useful either way, and the success of the experiment shows that it works.

Description

  • rewrite ruby code in Python
  • Add target in scripts to execute it with bazel
  • remove code from rake file and rake tasks
  • run target as part of format_code script

Motivation and Context

  • I added copyright check to build as part of release, but it doesn't really belong there
  • Copyright should get run on every RBE execution as part of the linter to make sure each commit is correct
  • This is the first step Ok, it's 2 lines to add it to the linter so I did it with this PR

You can see from my little experiment here - fdf14af
that it found all 4 issues: https://github.com/SeleniumHQ/selenium/actions/runs/7660852315/job/20879036168?pr=13512

@titusfortner titusfortner added the C-build Build related issues (bazel and CI) label Jan 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (168c9f5) 58.48% compared to head (159f953) 58.48%.
Report is 6 commits behind head on trunk.

❗ Current head 159f953 differs from pull request most recent head 7a01ba4. Consider uploading reports for the commit 7a01ba4 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13512   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files          86       86           
  Lines        5270     5270           
  Branches      220      220           
=======================================
  Hits         3082     3082           
  Misses       1968     1968           
  Partials      220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner force-pushed the copyright branch 2 times, most recently from 242f39b to 39f3eb4 Compare January 26, 2024 21:45
@titusfortner
Copy link
Member Author

Hmm, I'm not sure why the final commit doesn't have any checks?

@titusfortner titusfortner merged commit 8186582 into trunk Jan 29, 2024
10 checks passed
@titusfortner titusfortner deleted the copyright branch January 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build Build related issues (bazel and CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants