-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] add deprecation library requirement #13402
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13402 +/- ##
=======================================
Coverage 58.23% 58.23%
=======================================
Files 86 86
Lines 5265 5265
Branches 222 222
=======================================
Hits 3066 3066
Misses 1977 1977
Partials 222 222 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be added. Deprecating something in Python should not be as complicated as it is currently.
@isaulv @AutomatedTester @symonk |
@titusfortner @symonk @isaulv @AutomatedTester This decorator is implemented in Python 3.13. PEP 702 (https://peps.python.org/pep-0702/). So going forward once python 3.13 is released, we can avoid the dependency on deprecation library since the decorator is already implemented in |
@sandeepsuryaprasad We have to continue supporting users on 3.12 and below until ~2028. |
@titusfortner yes it is. the new decorator will be added to |
@sandeepsuryaprasad — but this still won't be available until October? |
@titusfortner Yes.. you are right.. this feature won't be available until October-24. |
There were two packages I saw:
It looks like the official deprecation implementation in 4.13 is going to be very basic as well, no bells, no whistles. In fact, the syntax looks exactly the same as the Deprecated package syntax. @AutomatedTester what do you think about using this package, adding the annotations as necessary and then just removing this library and replacing it with the standard one in October? |
I think this should be fine to add. I am always trying to limit third party but if we feel it will add value (I don't think there is much in terms of deprecation at the moment) |
Well, there are a few Firefox things that @diemol didn't deprecate because it was complicated. 😂 And I was going to use it to deprecate some Selenium Manager things, but we've decided we can just remove instead of deprecate Selenium Manager things while it is still in beta. |
Hmm, it looks like we might be able to use this already? |
f713ef5
to
68d3559
Compare
And I verified this works. Nice. |
Description
Add a dependency on deprecation library
Motivation and Context
Current means of doing deprecations in Python is challenging.
Using an annotation would be much easier
Notes
What do y'all think?