Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Possibility to output internal log messages to file #13249

Merged
merged 85 commits into from
Dec 7, 2023

Conversation

nvborisenko
Copy link
Member

Continue improvement of internal logging.

Description

  • Added FileLogHandler class which listens to internal log events
  • Fixed issue when copying of log handlers across contexts

Motivation and Context

To be aligned with others bindings, and providing file log handler out of the box.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner added this to the 4.17 milestone Dec 7, 2023
@nvborisenko
Copy link
Member Author

This change introduces a breaking change to ILogHandler. I even don't mind to land this feature as v4.16.2. Then docs will be aligned across bindings.

Why now rather than later?
Stabilize public API and avoid breaking changes in future.

@nvborisenko
Copy link
Member Author

Thanks @nvborisenko for your contribution!

@nvborisenko nvborisenko merged commit b949dca into SeleniumHQ:trunk Dec 7, 2023
11 checks passed
@nvborisenko nvborisenko deleted the dotnet-logging-file branch December 8, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants