-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] adds more tests for java support event class #13198
Conversation
I haven't run the tests, yet, but I think you need to run |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13198 +/- ##
==========================================
+ Coverage 57.52% 57.53% +0.01%
==========================================
Files 86 86
Lines 5299 5310 +11
Branches 221 221
==========================================
+ Hits 3048 3055 +7
- Misses 2030 2034 +4
Partials 221 221 ☔ View full report in Codecov by Sentry. |
@titusfortner sounds good, got other pr's out so Ill run the same format script on them as well |
java/test/org/openqa/selenium/support/events/EventFiringDecoratorTest.java
Outdated
Show resolved
Hide resolved
java/test/org/openqa/selenium/support/events/EventFiringDecoratorTest.java
Outdated
Show resolved
Hide resolved
@titusfortner whoops good catch, missed that on the commit. Added both back and now and it passes locally |
@RevealOscar can you rebase the changes after I merged the other PR? Thanks. |
oh ew, I mightve messed something up when doing it via intellij. One sec Ill fix it |
af62ae1
to
57b050f
Compare
Yeah when we merge on GitHub then try to rebase locally it's always a pain. I wish the default on GH was to rebase. Anyway, I rebased and am re-running will merge when tests pass. Thanks. |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
extension of #12578
Added tests and fixed a small ordering issue in WebDriverListener, this puts it more int line with the rest of the method params
Description
Motivation and Context
Types of changes
Checklist