Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] adds more tests for java support event class #13198

Merged
merged 5 commits into from
Dec 3, 2023

Conversation

LogicOscar
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

extension of #12578

Added tests and fixed a small ordering issue in WebDriverListener, this puts it more int line with the rest of the method params

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner
Copy link
Member

I haven't run the tests, yet, but I think you need to run ./scripts/format.sh on this.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7763c5b) 57.52% compared to head (65d841a) 57.53%.
Report is 31 commits behind head on trunk.

❗ Current head 65d841a differs from pull request most recent head af62ae1. Consider uploading reports for the commit af62ae1 to get more accurate results

Files Patch % Lines
py/selenium/webdriver/common/bidi/cdp.py 0.00% 4 Missing ⚠️
py/selenium/webdriver/remote/webelement.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13198      +/-   ##
==========================================
+ Coverage   57.52%   57.53%   +0.01%     
==========================================
  Files          86       86              
  Lines        5299     5310      +11     
  Branches      221      221              
==========================================
+ Hits         3048     3055       +7     
- Misses       2030     2034       +4     
  Partials      221      221              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LogicOscar
Copy link
Contributor Author

@titusfortner sounds good, got other pr's out so Ill run the same format script on them as well

@LogicOscar
Copy link
Contributor Author

@titusfortner whoops good catch, missed that on the commit. Added both back and now and it passes locally
image

@titusfortner titusfortner added this to the 4.16 milestone Nov 27, 2023
@titusfortner
Copy link
Member

@RevealOscar can you rebase the changes after I merged the other PR? Thanks.

@LogicOscar
Copy link
Contributor Author

oh ew, I mightve messed something up when doing it via intellij. One sec Ill fix it

@titusfortner
Copy link
Member

Yeah when we merge on GitHub then try to rebase locally it's always a pain. I wish the default on GH was to rebase. Anyway, I rebased and am re-running will merge when tests pass. Thanks.

@titusfortner titusfortner merged commit 015595d into SeleniumHQ:trunk Dec 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants