Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Refactored code in the WebDriverException class: #12933

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

manuelsblanco
Copy link
Contributor

  • Replaced the filter expression from checking if a string is not null or empty using s == null || s.equals("") to s == null || s.isEmpty().

Updated a comment in the public enum WindowType:

  • Changed the comment from "Represents the type of a new browser window that may be created." to "Represents the type of new browser window that may be created."

Description

Corrected a typo and used the IsEmpty() method instead of comparing with an empty string

Motivation and Context

Improve code quality by using the appropriate type of comparison

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

manuelsblanco and others added 3 commits October 11, 2023 17:56
- Replaced the filter expression from checking if a string is not null or empty using s == null || s.equals("") to s == null || s.isEmpty().

Updated a comment in the public enum WindowType:
- Changed the comment from "Represents the type of a new browser window that may be created." to "Represents the type of new browser window that may be created."
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0a3d590) 56.51% compared to head (bfbedea) 56.51%.

❗ Current head bfbedea differs from pull request most recent head b2eb9e1. Consider uploading reports for the commit b2eb9e1 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12933   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2970     2970           
  Misses       2098     2098           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pujagani pujagani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @manuelsblanco!

@pujagani pujagani merged commit 7cc250f into SeleniumHQ:trunk Oct 12, 2023
37 of 43 checks passed
@manuelsblanco manuelsblanco deleted the isEmptyImprovement branch October 12, 2023 14:49
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants