Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] allow setting version in the Http Client Config #12919

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

titusfortner
Copy link
Member

Description

Adds version to the constructor and all the methods for Http Client Config
I didn't add tests because our current tests don't seem to be testing the other parameters in a way I can manage. Would need some mocks that I don't have time to figure out.

Motivation and Context

Addresses #12918 since the default is HTTP 2

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f02e917) 56.51% compared to head (9ce1c80) 56.51%.
Report is 9 commits behind head on trunk.

❗ Current head 9ce1c80 differs from pull request most recent head 64bcbd7. Consider uploading reports for the commit 64bcbd7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12919   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2970     2970           
  Misses       2098     2098           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner merged commit dd00a0a into trunk Oct 11, 2023
40 of 43 checks passed
@titusfortner titusfortner deleted the client_version branch October 11, 2023 23:04
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
)

* [java] allow setting version in the Http Client Config

* [java] set client config version as string and convert in Jdk Client
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 29, 2023
)

* [java] allow setting version in the Http Client Config

* [java] set client config version as string and convert in Jdk Client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants