Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] remove lift related packages and dependencies #12917

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

joerg1985
Copy link
Member

Description

Remove lift related packages and dependencies.

Motivation and Context

This is the follow up PR to #12263, removing the deprecated code.

The Wiki-Page should be deleted.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner merged commit 06bb4e9 into SeleniumHQ:trunk Oct 10, 2023
12 checks passed
@joerg1985
Copy link
Member Author

@titusfortner is it okay, when i delete the wiki page? Or is there something to consider before deleting it?

@titusfortner
Copy link
Member

go for it

@titusfortner
Copy link
Member

Well, actually I copied a lot of the old stuff to the legacy section of our website

@titusfortner
Copy link
Member

If you think there's any historical value to it (but i don't think there is?)

@joerg1985
Copy link
Member Author

I agree, this is nothing historical.

aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
@chabala
Copy link

chabala commented Oct 11, 2024

Seems I'm a little late to the party here. I was just thinking 'surely someone has already made Hamcrest matchers for working with Selenium', and found the Lift artifact. Then I spent longer trying to find out 'what is Selenium Lift?', and eventually found this issue, and #12263.

Obviously I'll always have the existing artifact in Maven to use, but if I were to advocate for the code to return from being deleted, I'd love to see a 'just the matchers' artifact with minimal dependencies beyond Hamcrest & Selenium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants