Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] use the java process builder to run external processes #12898

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

joerg1985
Copy link
Member

Description

Replaced commons-exec with the java process builder to get rid of the dependency.

Motivation and Context

With Java 11 we now have all we need to implement the same functionality without a dependency.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0f8e018) 56.51% compared to head (541f72c) 56.51%.
Report is 1 commits behind head on trunk.

❗ Current head 541f72c differs from pull request most recent head 2877334. Consider uploading reports for the commit 2877334 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12898   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2970     2970           
  Misses       2098     2098           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joerg1985 joerg1985 changed the title [java] replaced commons-exec with the java process builder [java] use the java process builder to run external processes Oct 9, 2023
@titusfortner
Copy link
Member

Oh shoot, I was going to merge this before 4.14. :(

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@mykola-mokhnach @SrinivasanTarget @valfirst, does this affect Appium?

@mykola-mokhnach
Copy link

Thank you, @joerg1985!

@mykola-mokhnach @SrinivasanTarget @valfirst, does this affect Appium?

yes it does: appium/java-client#2036 (comment)

That is why I have requested this feature

@diemol
Copy link
Member

diemol commented Oct 11, 2023

Thank you, @joerg1985!
@mykola-mokhnach @SrinivasanTarget @valfirst, does this affect Appium?

yes it does: appium/java-client#2036 (comment)

That is why I have requested this feature

OK, so you are already checking this. We should be able to merge this anytime, @joerg1985.

@valfirst
Copy link
Contributor

@mykola-mokhnach it seems you mixed up PRs, this one about process management

@diemol it affects Appium, but I'm not sure how much, anyway once SNAPSHOT is published, it can be tested

@titusfortner titusfortner merged commit 7ddfad6 into SeleniumHQ:trunk Oct 11, 2023
45 of 48 checks passed
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants