Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] allow user to start service before creating driver #12816

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

titusfortner
Copy link
Member

Description

Create a GetDefaultDriverOptions() method in each driver service class to allow passing to the DriverFinder method if starting the driver without a provided location.

Motivation and Context

Fixes #12805
Similar to how 5bce8d9 fixes #12682

@titusfortner titusfortner merged commit e66fbf5 into trunk Sep 25, 2023
14 of 15 checks passed
@titusfortner titusfortner deleted the 12805 branch September 25, 2023 13:00
@madushag
Copy link

madushag commented Oct 19, 2023

@titusfortner I don't believe this issue has been addressed entirely. I'm running into the same error message as documented in #12805 using the latest version of Selenium (4.14.1).

While debugging through the code, I see that this call to DriverFinder.FullPath(GetDefaultDriverOptions()); (line 221) isn't setting the private members driverServicePath and driverServiceExecutableName, which I believe in turn causes the call to driverServiceProcess.StartInfo.FileName = Path.Combine(driverServicePath, driverServiceExecutableName); in DriverService.cs to fail at line 224.
git-errror

@nvborisenko
Copy link
Member

I have reopened that issue, thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants