Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Remove browserVersion from options in SM Java wrapper (fix #12633) #12639

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR remove the browserVersion from options in the SM Java wrapper.

Motivation and Context

This PR fixes #12633 in the Java bindings.

According to @titusfortner info, this is already done in Ruby, Python, and .Net:

https://github.com/SeleniumHQ/selenium/blob/trunk/rb/lib/selenium/webdriver/common/selenium_manager.rb#L50
https://github.com/SeleniumHQ/selenium/blob/trunk/py/selenium/webdriver/common/selenium_manager.py#L103
https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/SeleniumManager.cs#L109

Does anybody know if JavaScript also removes browserVersion from options in the SM wrapper class?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia merged commit a124440 into trunk Aug 30, 2023
50 of 52 checks passed
@bonigarcia bonigarcia deleted the java_sm_browser_version branch August 30, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Browser version labels (stable, beta, dev, nightly) are not supported in Firefox (java)
2 participants