Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Simplfy to only target .NET Standard 2.0 #12608

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

jimevans
Copy link
Member

Description

Simplifies the .NET bindings to produce assembly artifacts only targeting .NET Standard 2.0, instead of multi-targeting many different versions of the .NET Frameworks.

Motivation and Context

Rather than targeting multiple individual target framework versions, simplify the project targeting to only target .NET Standard 2.0. Doins so, the resulting assemblies will be usable by projects targeting any of the following versions:

  • .NET Framework: 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1
  • .NET Core: 2.0, 2.1, 2.2, 3.0, 3.1
  • .NET versions: 5.0, 6.0, 7.0

Additionally, they will be usable from the Mono and Xamarin frameworks.

This will simplify the build process and maintenance going forward, and will allow the project to greatly reduce the complexity of the Bazel builds.

As a note, this does remove support for .NET 4.5.x, the last version of which (4.5.2) was released in 2014, and reached end-of-life in April 2022.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Rather than targeting multiple individual target framework versions,
simplify the project targeting to only target .NET Standard 2.0. Doins
so, the resulting assemblies will be usable by projects targeting any of
the following versions:

* .NET Framework: 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1
* .NET Core: 2.0, 2.1, 2.2, 3.0, 3.1
* .NET versions: 5.0, 6.0, 7.0

Additionally, they will be usable from the Mono and Xamarin frameworks.

This will simplify the build process and maintenance going forward, and
will allow the project to greatly reduce the complexity of the Bazel
builds.

As a note, this does remove support for .NET 4.5.x, the last version
of which (4.5.2) was released in 2014, and reached end-of-life in
April 2022.
@titusfortner
Copy link
Member

So this effectively removes users of net45
Which I think is deprecated?

I'm a little delete happy these days, so I'm not going to complain, just wanted to verify.

Also, I had someone I trust say:

net472 (fixes an issue where you support both .NET FX and .NET Standard 2.0)

Is this something we should include as well?

Regardless, thank you! This will make building things much easier at least 😂

@nvborisenko
Copy link
Member

This PR makes everybody's live so much easier. Two hands up for being it merged.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@diemol diemol merged commit 76702df into trunk Aug 25, 2023
10 of 12 checks passed
@diemol diemol deleted the simplify-dotnet-targets branch August 25, 2023 07:51
CandorContent pushed a commit to CandorContent/selenium that referenced this pull request Aug 25, 2023
* [dotnet] Simplfy to only target .NET Standard 2.0

Rather than targeting multiple individual target framework versions,
simplify the project targeting to only target .NET Standard 2.0. Doins
so, the resulting assemblies will be usable by projects targeting any of
the following versions:

* .NET Framework: 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1
* .NET Core: 2.0, 2.1, 2.2, 3.0, 3.1
* .NET versions: 5.0, 6.0, 7.0

Additionally, they will be usable from the Mono and Xamarin frameworks.

This will simplify the build process and maintenance going forward, and
will allow the project to greatly reduce the complexity of the Bazel
builds.

As a note, this does remove support for .NET 4.5.x, the last version
of which (4.5.2) was released in 2014, and reached end-of-life in
April 2022.

* Add forgotten change to csproj file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants