[dotnet] Use selenium manager in tests

[nvborisenko]

Thanks for contributing to Selenium!
Related to #11304

Now it's not necessary to store driver binaries on machine where tests are executing, Selenium Manager does it.

To tests these changes: remove c:\Projects\WebDriverServers\ directory and tests should be passed.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[titusfortner]

Oh nice, this was annoying. If the tests are passing....

[nvborisenko]

1 test failed:

Failed ShouldBeAbleToUploadTheSameFileTwice [468 ms]
  Error Message:
   OpenQA.Selenium.NoSuchElementException : Unable to locate element: #upload
  Stack Trace:
     at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute) in D:\a\selenium\selenium\dotnet\src\webdriver\WebDriver.cs:line 703
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters) in D:\a\selenium\selenium\dotnet\src\webdriver\WebDriver.cs:line 576
   at OpenQA.Selenium.WebDriver.FindElement(String mechanism, String value) in D:\a\selenium\selenium\dotnet\src\webdriver\WebDriver.cs:line 308
   at OpenQA.Selenium.By.<.ctor>b__11_0(ISearchContext context) in D:\a\selenium\selenium\dotnet\src\webdriver\By.cs:line 71
   at OpenQA.Selenium.By.FindElement(ISearchContext context) in D:\a\selenium\selenium\dotnet\src\webdriver\By.cs:line 336
   at OpenQA.Selenium.WebDriver.FindElement(By by) in D:\a\selenium\selenium\dotnet\src\webdriver\WebDriver.cs:line 294
   at OpenQA.Selenium.FormHandlingTests.ShouldBeAbleToUploadTheSameFileTwice() in D:\a\selenium\selenium\dotnet\test\common\FormHandlingTests.cs:line 216

Can somebody re-trigger tests again, just to understand whether it's flaky. BTW it is passing locally.

[nvborisenko]

Retriggered by myself.

Failed ShouldBeAbleToUploadTheSameFileTwice [441 ms]
  Error Message:
   OpenQA.Selenium.NoSuchElementException : Unable to locate element: #upload
  Stack Trace:
     at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute) in D:\a\selenium\selenium\dotnet\src\webdriver\WebDriver.cs:line 703
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters) in D:\a\selenium\selenium\dotnet\src\webdriver\WebDriver.cs:line 576
   at OpenQA.Selenium.WebDriver.FindElement(String mechanism, String value) in D:\a\selenium\selenium\dotnet\src\webdriver\WebDriver.cs:line 308
   at OpenQA.Selenium.By.<.ctor>b__11_0(ISearchContext context) in D:\a\selenium\selenium\dotnet\src\webdriver\By.cs:line 71
   at OpenQA.Selenium.By.FindElement(ISearchContext context) in D:\a\selenium\selenium\dotnet\src\webdriver\By.cs:line 336
   at OpenQA.Selenium.WebDriver.FindElement(By by) in D:\a\selenium\selenium\dotnet\src\webdriver\WebDriver.cs:line 294
   at OpenQA.Selenium.FormHandlingTests.ShouldBeAbleToUploadTheSameFileTwice() in D:\a\selenium\selenium\dotnet\test\common\FormHandlingTests.cs:line 216

Now it is failing twice (per 2 target framework).

What is changed:

• geckodriver now is the latest

Any clues?

[titusfortner]

I think I've seen it before. Likely a timing issue? It's not going to be related to this PR at least.

[nvborisenko]

This is what I see when reproduced the issue sporadically.

[diemol]

I'll test this locally because Selenium Manager is not used in GitHub actions. The runner has drivers on the path.

[nvborisenko]

I tested it locally, I have no driver in %PATH%, selenium manager is used. Moreover I fixed flaky test.

Next step is remove drivers from PATH in GitHub actions? Here I am asking help, because I am not sure where exactly drivers are copied in workflow.

[titusfortner]

What is installed on the runners can be found in this repo — https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md#environment-variables-1

[titusfortner]

We should figure out how to remove the directory from PATH or see if we can delete the driver itself.

[nvborisenko]

You are right, there is CHROMEWEBDRIVER env var, and also the drivers are defined in PATH env. I am going to delete drivers physically from drive C:

[nvborisenko]

All done, driver are physically deleted. Tests passed.

VERBOSE: Performing the operation "Remove Directory" on target "C:\SeleniumWebDrivers\ChromeDriver".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\ChromeDriver\chromedriver.exe".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\ChromeDriver\LICENSE.chromedriver".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\ChromeDriver\versioninfo.txt".
VERBOSE: Performing the operation "Remove Directory" on target "C:\SeleniumWebDrivers\EdgeDriver".
VERBOSE: Performing the operation "Remove Directory" on target "C:\SeleniumWebDrivers\EdgeDriver\Driver_Notes".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\EdgeDriver\Driver_Notes\credits.html".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\EdgeDriver\Driver_Notes\EULA".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\EdgeDriver\Driver_Notes\LICENSE".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\EdgeDriver\msedgedriver.exe".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\EdgeDriver\versioninfo.txt".
VERBOSE: Performing the operation "Remove Directory" on target "C:\SeleniumWebDrivers\GeckoDriver".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\GeckoDriver\geckodriver.exe".
VERBOSE: Performing the operation "Remove File" on target "C:\SeleniumWebDrivers\GeckoDriver\versioninfo.txt".

[diemol]

My apologies, @nvborisenko, I made changes in SeleniumManager that caused the conflict. Would you be able to fix it whenever you get some time? Thank you.

[diemol]

Thank you, @nvborisenko!