Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/deprecation message for standalone3x #11422

Merged
merged 5 commits into from
Dec 13, 2022
Merged

feat/deprecation message for standalone3x #11422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc73765
feat/deprecation message for standalone3x
potapovDim Dec 13, 2022
ed0496b
Merge branch 'trunk' into feat/deprecation-message-for-standalone3x
potapovDim Dec 13, 2022
a45cffc
Update javascript/node/selenium-webdriver/remote/util.js
potapovDim Dec 13, 2022
5ce731d
Merge branch 'trunk' into feat/deprecation-message-for-standalone3x
potapovDim Dec 13, 2022
48eef35
Merge branch 'trunk' into feat/deprecation-message-for-standalone3x
potapovDim Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions javascript/node/selenium-webdriver/remote/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const cmd = require('../lib/command')
const input = require('../lib/input')
const net = require('../net')
const portprober = require('../net/portprober')
const logging = require('../lib/logging')

const { getJavaPath, formatSpawnArgs } = require('./util')

Expand Down Expand Up @@ -119,6 +120,8 @@ class DriverService {
* @param {!ServiceOptions} options Configuration options for the service.
*/
constructor(executable, options) {
/** @private @const */
this.log_ = logging.getLogger('webdriver.DriverService')
/** @private {string} */
this.executable_ = executable

Expand Down
5 changes: 4 additions & 1 deletion javascript/node/selenium-webdriver/remote/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ function isSelenium3x(seleniumStandalonePath) {
* @returns {Array.<string>}
*/
function formatSpawnArgs(seleniumStandalonePath, args) {
if (isSelenium3x(seleniumStandalonePath)) return args
if (isSelenium3x(seleniumStandalonePath)) {
console.warn('Deprecation: Support for Standalone Server 3.x will be removed soon. Please update to version 4.x')
return args
}

const standaloneArg = 'standalone'
const port3xArgFormat = '-port'
Expand Down