Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Capture error output from selenium manager #11320

Merged
merged 2 commits into from
Nov 26, 2022
Merged

[dotnet] Capture error output from selenium manager #11320

merged 2 commits into from
Nov 26, 2022

Conversation

nvborisenko
Copy link
Member

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

If selenium manager binary fails then user sees exception

OpenQA.Selenium.WebDriverException : Invalid response from process: selenium-manager/windows/selenium-manager.exe 12345
error: Found argument '12345' which wasn't expected, or isn't valid in this context

Usage: selenium-manager.exe [OPTIONS]

For more information try '--help'

Motivation and Context

Related to #11301

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko nvborisenko changed the title Capture error output from selenium manager [dotnet] Capture error output from selenium manager Nov 25, 2022
Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except we don't want the user actually seeing these error messages (yet), so we need to keep the try/catch in the DriverService.

@titusfortner titusfortner merged commit 0ea5e3e into SeleniumHQ:trunk Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants