-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] extend typing options for get_property() #10682
Conversation
8561155
to
ee14f4b
Compare
Codecov Report
@@ Coverage Diff @@
## trunk #10682 +/- ##
=======================================
Coverage 46.61% 46.61%
=======================================
Files 86 86
Lines 5848 5848
Branches 278 278
=======================================
Hits 2726 2726
Misses 2844 2844
Partials 278 278
Continue to review full report at Codecov.
|
@eNcacz looks like we've updated to Python 3 syntax for this, can you update this PR so we can merge it? Thanks! |
1081eca
to
52c9eb8
Compare
fixes #10624
Extend list of types which can be returned byt
get_property()
method.Description
Current typing options does not cover all possible types returned by get_property()
For example
clientHeight
property is returned as intfooBar
property is returned as NoneTypechildNodes
property is returned as listMotivation and Context
Linters (like mypy or PyCharm) complains about
get_property()
usage when we expect one of mentioned data type.Types of changes
Checklist