Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] remove opera #10630

Merged
merged 5 commits into from
Jun 14, 2022
Merged

[py] remove opera #10630

merged 5 commits into from
Jun 14, 2022

Conversation

symonk
Copy link
Member

@symonk symonk commented May 10, 2022

4.2 seen the deprecation of opera; I have opened this for now to account for the removal of it altogether; will re base later once we ship 4.2 and get this in for 4.3.

#10379 will be considered done as far as the python bindings are concerned in 4.3

@titusfortner @AutomatedTester we originally thought 4.3 for opera removal; but it's only deprecated in 4.2 however the message does say it'll be removed in 4.3 specifically; whatever you think tho, maybe 4.4 for this? I'll keep the PR in sync atleast.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #10630 (1aa1d8b) into trunk (9a52775) will increase coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            trunk   #10630      +/-   ##
==========================================
+ Coverage   48.20%   48.48%   +0.28%     
==========================================
  Files          86       84       -2     
  Lines        5570     5486      -84     
  Branches      279      276       -3     
==========================================
- Hits         2685     2660      -25     
+ Misses       2606     2550      -56     
+ Partials      279      276       -3     
Impacted Files Coverage Δ
py/selenium/webdriver/__init__.py 100.00% <ø> (ø)
.../selenium/webdriver/common/desired_capabilities.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a52775...1aa1d8b. Read the comment docs.

@symonk symonk added the C-py label May 14, 2022
@titusfortner titusfortner added this to the 4.3 milestone May 24, 2022
@symonk symonk changed the title [py] remove opera. [do not merge until 4.3 is available] [py] remove opera May 29, 2022
@symonk symonk merged commit 17907d3 into SeleniumHQ:trunk Jun 14, 2022
@symonk symonk deleted the remove-opera-completely branch June 14, 2022 19:20
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
[py]: Completely remove `opera` for `4.3`.
@divinity76
Copy link

Opera version 13+ is little more than a re-skin of Chromium right?

@titusfortner
Copy link
Member

@divinity76 yes, but operadriver is not properly supporting the w3c protocol which is required for Selenium 4, and we've had issues driving Opera with chromedriver recently because of some new features that Google has released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants