Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Support Webdriver commands for FedCM #12088

Open
cbiesinger opened this issue May 23, 2023 · 9 comments
Open

[🚀 Feature]: Support Webdriver commands for FedCM #12088

cbiesinger opened this issue May 23, 2023 · 9 comments
Labels

Comments

@cbiesinger
Copy link
Contributor

Feature and motivation

Expose these Webdriver commands in Selenium:
https://fedidcg.github.io/FedCM/#automation

I have a draft PR at #12087 (comment)

Usage example

This lets identity providers and relying parties use Selenium's Java API to control
the FedCM browser dialog to test that their website works correctly when
using the FedCM API.

@github-actions
Copy link

@cbiesinger, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@cbiesinger
Copy link
Contributor Author

cbiesinger commented May 23, 2023

(note that these commands are already supported in Chromedriver v115)

@titusfortner
Copy link
Member

Looks like this has been implemented in Java, so we just need to add it for the other bindings.

@titusfortner titusfortner added the help wanted Issues looking for contributions label Dec 31, 2023
Copy link

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

@aguspe
Copy link
Contributor

aguspe commented Apr 5, 2024

Hi, if it's okay and help is still wanted I will start working on this for the RB selenium binding, I will publish my PR during the weekend

@aguspe
Copy link
Contributor

aguspe commented Apr 10, 2024

I started working on this for the Ruby client, I'm just trying to read through the docs and adapt the java implementation to start with

cbiesinger added a commit to cbiesinger/selenium that referenced this issue Jun 3, 2024
This builds on commit 7ad44ee

The specification for clickdialogbutton is here:
https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton

The version that takes an index is specified here:
w3c-fedid/FedCM#610

Bug SeleniumHQ#12088
cbiesinger added a commit to cbiesinger/selenium that referenced this issue Jun 4, 2024
This builds on commit 7ad44ee

The specification for clickdialogbutton is here:
https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton

The version that takes an index is specified here:
w3c-fedid/FedCM#610

Bug SeleniumHQ#12088
cbiesinger added a commit to cbiesinger/selenium that referenced this issue Jun 4, 2024
This builds on commit 7ad44ee

The specification for clickdialogbutton is here:
https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton

The version that takes an index is specified here:
w3c-fedid/FedCM#610

Bug SeleniumHQ#12088
cbiesinger added a commit to cbiesinger/selenium that referenced this issue Jun 4, 2024
This builds on commit 7ad44ee

The specification for clickdialogbutton is here:
https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton

The version that takes an index is specified here:
w3c-fedid/FedCM#610

Bug SeleniumHQ#12088
cbiesinger added a commit to cbiesinger/selenium that referenced this issue Jun 5, 2024
This builds on commit 7ad44ee

The specification for clickdialogbutton is here:
https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton

The version that takes an index is specified here:
w3c-fedid/FedCM#610

Bug SeleniumHQ#12088
@aguspe
Copy link
Contributor

aguspe commented Jun 9, 2024

Hello the ruby implementation #13796 is up for review :)

@aguspe
Copy link
Contributor

aguspe commented Jul 16, 2024

Hello @p0deje should we remove the label rb for this? The ruby implementation was merged on this pr #13796, and I was just looking for rb related things to help out and this popped up again since I filtered based on rb

@navin772
Copy link
Contributor

Please remove the C-py label as the python changes have landed in #14710

@p0deje p0deje removed the C-py label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants