[🚀 Feature]: Grid properly matches enable download support #11658
Assignees
Labels
Comments
krmahadevan
added a commit
to krmahadevan/selenium
that referenced
this issue
Feb 23, 2023
Fixes SeleniumHQ#11656 SeleniumHQ#11658 Following has been done: * Specify the default base directory into which all downloads at a node will go into via the flag “—-base-dir-downloads”. If this flag does not have a value then we default to user’s home. * Turn ON managing download folders via the flag “-—enable-manage-downloads” * Enabled support for Chrome|Edge|Firefox browsers. * File downloads will be done only in a session aware directory for a given web driver session. After session is killed, the directory gets cleaned up as well.
8 tasks
krmahadevan
added a commit
to krmahadevan/selenium
that referenced
this issue
Feb 24, 2023
Fixes SeleniumHQ#11656 SeleniumHQ#11658 Following has been done: * Specify the default base directory into which all downloads at a node will go into via the flag “—-base-dir-downloads”. If this flag does not have a value then we default to user’s home. * Turn ON managing download folders via the flag “-—enable-manage-downloads” * Enabled support for Chrome|Edge|Firefox browsers. * File downloads will be done only in a session aware directory for a given web driver session. After session is killed, the directory gets cleaned up as well.
krmahadevan
added a commit
to krmahadevan/selenium
that referenced
this issue
Mar 1, 2023
Fixes SeleniumHQ#11656 SeleniumHQ#11658 Following has been done: * Specify the default base directory into which all downloads at a node will go into via the flag “—-base-dir-downloads”. If this flag does not have a value then we default to user’s home. * Turn ON managing download folders via the flag “-—enable-manage-downloads” * Enabled support for Chrome|Edge|Firefox browsers. * File downloads will be done only in a session aware directory for a given web driver session. After session is killed, the directory gets cleaned up as well.
krmahadevan
added a commit
to krmahadevan/selenium
that referenced
this issue
Mar 7, 2023
Fixes SeleniumHQ#11656 SeleniumHQ#11658 Following has been done: * Specify the default base directory into which all downloads at a node will go into via the flag “—-base-dir-downloads”. If this flag does not have a value then we default to user’s home. * Turn ON managing download folders via the flag “-—enable-manage-downloads” * Enabled support for Chrome|Edge|Firefox browsers. * File downloads will be done only in a session aware directory for a given web driver session. After session is killed, the directory gets cleaned up as well.
krmahadevan
added a commit
to krmahadevan/selenium
that referenced
this issue
Mar 10, 2023
Fixes SeleniumHQ#11656 SeleniumHQ#11658 Following has been done: * Specify the default base directory into which all downloads at a node will go into via the flag “—-base-dir-downloads”. If this flag does not have a value then we default to user’s home. * Turn ON managing download folders via the flag “-—enable-manage-downloads” * Enabled support for Chrome|Edge|Firefox browsers. * File downloads will be done only in a session aware directory for a given web driver session. After session is killed, the directory gets cleaned up as well.
diemol
added a commit
that referenced
this issue
Mar 15, 2023
* [Grid] Support auto downloads in Grid Fixes #11656 #11658 Following has been done: * Turn ON managing download folders via the flag “-—enable-manage-downloads” * Enabled support for Chrome|Edge|Firefox browsers. * File downloads will be done only in a session aware directory for a given web driver session. After session is killed, the directory gets cleaned up as well. * [grid] Renaming to manage downloads enabled and removing out of scope logic to determine Node match and client side validations * [grid] Using the temp file system utility With this, it will be transparent for the user where files are written, and since we use the caches then the deletion happens when the session is closed. Also, we do not need the `--base-dir-downloads` parameter. * [grid] Adding a cleanup executor for downloaded files * [grid] Adding e2e test and fixing bug found while adding test * [grid] Removing test --------- Co-authored-by: Diego Molina <[email protected]> Co-authored-by: Diego Molina <[email protected]>
|
Closed via #11702 |
alpatron
pushed a commit
to alpatron/selenium
that referenced
this issue
Mar 15, 2023
* [Grid] Support auto downloads in Grid Fixes SeleniumHQ#11656 SeleniumHQ#11658 Following has been done: * Turn ON managing download folders via the flag “-—enable-manage-downloads” * Enabled support for Chrome|Edge|Firefox browsers. * File downloads will be done only in a session aware directory for a given web driver session. After session is killed, the directory gets cleaned up as well. * [grid] Renaming to manage downloads enabled and removing out of scope logic to determine Node match and client side validations * [grid] Using the temp file system utility With this, it will be transparent for the user where files are written, and since we use the caches then the deletion happens when the session is closed. Also, we do not need the `--base-dir-downloads` parameter. * [grid] Adding a cleanup executor for downloaded files * [grid] Adding e2e test and fixing bug found while adding test * [grid] Removing test --------- Co-authored-by: Diego Molina <[email protected]> Co-authored-by: Diego Molina <[email protected]>
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature and motivation
This is an extension of #11656 but I wanted to separate it out.
We know we want the Grid to set whether it allows downloads. Right now we're doing a flag where we have users specify the directory. If we are creating that directory for users, that won't be necessary. We can either keep the flag and change it to
--enable-downloadsor we can do whatever we do now by requiring a match ofse:enableDownloadscapability. I kind of like the latter approach because if a user requests a session with downloads enabled, but the Hub doesn't find a node with it turned on, it would be nice to get a clear error message that this is the case.Usage example
backend implementation
The text was updated successfully, but these errors were encountered: