Skip to content

Commit

Permalink
[rb] fix bug with driver logging
Browse files Browse the repository at this point in the history
the io accessor for the process sets a default value, so assigning with ||= operator will never work
  • Loading branch information
titusfortner committed May 6, 2023
1 parent eec4236 commit e4e6362
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rb/lib/selenium/webdriver/common/service_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ def uri
def build_process(*command)
WebDriver.logger.debug("Executing Process #{command}", id: :driver_service)
@process = ChildProcess.build(*command)
@process.io = @io
@process.io ||= WebDriver.logger.io if WebDriver.logger.debug?
@io ||= WebDriver.logger.io if WebDriver.logger.debug?
@process.io = @io if @io

@process
end
Expand Down

0 comments on commit e4e6362

Please sign in to comment.