[java][bidi] Add validation for browsing context id (#12920)

Co-authored-by: Diego Molina <[email protected]> Co-authored-by: Titus Fortner <[email protected]> Co-authored-by: Puja Jagani <[email protected]>
SeleniumHQ · Oct 11, 2023 · bbcfc9a · bbcfc9a
1 parent 1f8b8d9
commit bbcfc9a
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/java/src/org/openqa/selenium/bidi/browsingcontext/BrowsingContext.java b/java/src/org/openqa/selenium/bidi/browsingcontext/BrowsingContext.java
@@ -76,6 +76,8 @@ public BrowsingContext(WebDriver driver, String id) {
       throw new IllegalArgumentException("WebDriver instance must support BiDi protocol");
     }
 
+    Require.precondition(!id.isEmpty(), "Browsing Context id cannot be empty");
+
     this.bidi = ((HasBiDi) driver).getBiDi();
     this.id = id;
   }
@@ -94,6 +96,9 @@ public BrowsingContext(WebDriver driver, WindowType type) {
   public BrowsingContext(WebDriver driver, WindowType type, String referenceContextId) {
     Require.nonNull("WebDriver", driver);
     Require.nonNull("Reference browsing context id", referenceContextId);
+
+    Require.precondition(!referenceContextId.isEmpty(), "Reference Context id cannot be empty");
+
     if (!(driver instanceof HasBiDi)) {
       throw new IllegalArgumentException("WebDriver instance must support BiDi protocol");
     }