Skip to content

Commit

Permalink
Resolve flakiness in atoms tests.
Browse files Browse the repository at this point in the history
Extends timeouts to resolve flakiness in history_test, inject_test, and
mouse_test.

Verified for 1000 runs of Chrome on Windows 7.

Signed-off-by: Jason Juang <[email protected]>
  • Loading branch information
joshbruning authored and juangj committed Jan 25, 2016
1 parent 83984c0 commit 918be03
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion javascript/atoms/test/history_test.html
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
}

function setUpPage() {
goog.testing.TestCase.getActiveTestCase().promiseTimeout = 10000; // 10s
goog.testing.TestCase.getActiveTestCase().promiseTimeout = 30000; // 30s
}

function setUp() {
Expand Down
4 changes: 4 additions & 0 deletions javascript/atoms/test/inject_test.html
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@

var frame, frameWin, frameDoc;

function setUpPage() {
goog.testing.TestCase.getActiveTestCase().promiseTimeout = 30000; // 30s
}

function setUp() {
frame = goog.dom.$('test-frame');
frameWin = goog.dom.getFrameContentWindow(frame);
Expand Down
1 change: 1 addition & 0 deletions javascript/atoms/test/mouse_test.html
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
redDiv = bot.locators.findElement({id: 'red'});
captureDiv = bot.locators.findElement({id: 'capture'});
innerCaptureDiv = bot.locators.findElement({id: 'innerCapture'});
goog.testing.TestCase.getActiveTestCase().promiseTimeout = 30000; // 30s
}

function setUp() {
Expand Down

0 comments on commit 918be03

Please sign in to comment.