Skip to content

Commit

Permalink
Add temporary iOS platform to aid W3C migration (#4559)
Browse files Browse the repository at this point in the history
In some cases we cannot consider platform and platformName to be
equivalent. For example, SauceLabs uses platformName and not
platform to run Appium tests. If we override platformName (iOS) with
platform (Mac, because no iOS platform exists), we generate a set of
invalid capabilities to actually run the browser test.

Fixes #4557
  • Loading branch information
matthewdoerksen authored and lukeis committed Aug 23, 2017
1 parent 466c084 commit 3e0e6ff
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions java/client/src/org/openqa/selenium/Platform.java
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,16 @@ public Platform family() {
}
},

/**
* Provide a temporary workaround for an issue where platformName was being overridden by
* platform for external providers.
*/
@Deprecated
IOS("iOS") {
@Override
public Platform family() { return MAC; }
},

/**
* Never returned, but can be used to request a browser running on any operating system.
*/
Expand Down

0 comments on commit 3e0e6ff

Please sign in to comment.