Docker: Update condition to enable tracing to avoid annoying warning messages #2541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #2355
Fixes #2415
Fixes #2423
Fixes #2432
Fixes #2481
By default,
SE_ENABLE_TRACING
istrue
to align with CLI option config https://www.selenium.dev/documentation/grid/configuration/cli_options/#loggingIt is recommended that the user enable observability for tracing issues if having any. However, by default, it auto config the endpoint to a local OTLP
localhost/[0:0:0:0:0:0:0:1]:4317
and raises the warning if endpoint is unreachable.This warning might annoy users or cause messed up logs to identify another real issue.
Instead of repetitively asking the user to add env var
SE_ENABLE_TRACING=false
, updating the condition to enable this feature should beSE_ENABLE_TRACING=true
, and users have to input a correct endpoint to env varSE_OTEL_EXPORTER_ENDPOINT
. Otherwise, it is disabled.Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
SE_ENABLE_TRACING=true
andSE_OTEL_EXPORTER_ENDPOINT
to be setSE_ENABLE_TRACING=false
from all docker-compose files to simplify configurationChanges walkthrough 📝
start-selenium-grid-distributor.sh
Update tracing condition in distributor script
Distributor/start-selenium-grid-distributor.sh
SE_OTEL_EXPORTER_ENDPOINT to be set
start-selenium-grid-hub.sh
Update tracing condition in hub script
Hub/start-selenium-grid-hub.sh
SE_OTEL_EXPORTER_ENDPOINT
docker-compose-v3.yml
Remove tracing configuration from compose file
docker-compose-v3.yml