Experimental: Selenium Grid scaler with different nodeMaxSessions per node #2402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Before, autoscaling recommends each Node should have 1 session. However, due to user demand, and Node also can configure a different number of max sessions per node via
SE_NODE_MAX_SESSIONS
Once Node is set the max sessions greater than 1, the scaler trigger parameter
nodeMaxSessions
need to be set for calculation can be aware Node capacity will be scaled up. Refer to https://github.com/SeleniumHQ/docker-selenium/blob/trunk/.keda/scalers/selenium-grid-scaler.mdThis is still an experimental feature, so it requires KEDA core components image tag with the patch scaler implementation - see https://github.com/SeleniumHQ/docker-selenium/blob/trunk/.keda/README.md
Types of changes
Checklist
PR Type
Enhancement, Tests, Documentation
Description
nodeMaxSessions
for each browser node (Chrome, Firefox, Edge) in Selenium Grid.nodeMaxSessions
and authentication references in scaler triggers.Changes walkthrough 📝
1 files
video.sh
Fix spacing in GraphQL endpoint error message
Video/video.sh
6 files
chart_test.sh
Add max session configuration for browser nodes
tests/charts/make/chart_test.sh
Makefile
Configure max sessions for autoscaling tests
Makefile
tests.
node-configmap.yaml
Remove SE_DRAIN_AFTER_SESSION_COUNT configuration
charts/selenium-grid/templates/node-configmap.yaml
values.yaml
Add nodeMaxSessions configuration and update kubectl image
charts/selenium-grid/values.yaml
dummy.yaml
Configure nodeMaxSessions in dummy render template
tests/charts/templates/render/dummy.yaml
dummy_solution.yaml
Configure nodeMaxSessions in dummy solution template
tests/charts/templates/render/dummy_solution.yaml
1 files
test.py
Add tests for scaler triggers and nodeMaxSessions
tests/charts/templates/test.py
1 files
_helpers.tpl
Add nodeMaxSessions to autoscaling and pod templates
charts/selenium-grid/templates/_helpers.tpl
2 files
README.md
Update KEDA core Helm chart link
.keda/README.md
CONFIGURATION.md
Document nodeMaxSessions and update kubectl image
charts/selenium-grid/CONFIGURATION.md