Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#1888): TimeZone change behavior changed #2031

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fix #1888

Motivation and Context

Update the command to set timezone as per request #1888. The result would be

Step 7/19 : RUN ln -fs /usr/share/zoneinfo/${TZ} /etc/localtime &&     dpkg-reconfigure -f noninteractive tzdata &&     cat /etc/timezone
 ---> Running in 5ddabe277c0d

Current default time zone: 'Asia/Shanghai'
Local time is now:      Wed Nov 29 03:16:57 CST 2023.
Universal Time is now:  Tue Nov 28 19:16:57 UTC 2023.

Asia/Shanghai

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@diemol diemol merged commit e3304b4 into SeleniumHQ:trunk Nov 29, 2023
3 checks passed
@VietND96 VietND96 deleted the minor-updates branch November 29, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: TimeZone change behavior changed
2 participants