-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chart): Error setting name in helm release #2006 #2007 #2009
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
It looks like |
@VietND96 can you please solve the merge conflicts? |
# Conflicts: # .github/workflows/helm-chart-test.yml # charts/selenium-grid/Chart.yaml
@diemol, I resolved conflicts. Can you approve workflow runs to check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @VietND96!
|
Ohh, Lint issue under testing values :( I am fixing it now |
Signed-off-by: Viet Nguyen Duc <[email protected]>
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fix: Error setting name in helm release #2006 & #2007
Motivation and Context
After PR #1989, template
.fullName
was updated in podTemplate. However, it caused a mismatch betweenselector
and the templatelabels
, which caused the helm command gets failed when component set.nameOverride
In part of this PR also contains:
charts/selenium-grid/ci/*-values.yaml
. This folder is excluded from package chart production via.helmignore
to avoid confusion from the user.ct
action is located usertests/chart-test.yaml
Types of changes
Checklist