fix(chart): Improve default value for videoRecorder #1984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Improve default value for videoRecorder in chart after #1881
Motivation and Context
Currently, by default,
videoRecorder.enabled=false
. When enabling videoRecorder, with defaultuploader: s3
in chart values.yaml. User must input the appropriate value foruploadDestinationPrefix
. Otherwise, the video container will be exited immediately (as video.sh in ConfigMap implemented).In my point of view, in common use cases, not always the user has S3 destination ready. Basically, by default, all containers in the pod should be up fully before going to advanced configs. Use cases with the order of priority would be
videoRecorder.enabled=false
. Node pod has 1/1 container running.--set videoRecorder.enabled=true
only. Node pod has 2/2 containers running. Video records are persisted in PersistentVolume in Kubernetes.--set videoRecorder.uploader=s3 --set videoRecorder.uploadDestinationPrefix=s3://myvideobucket/
. Node pod has 3/3 containers running, and records are uploaded properly to destination S3.Update to use the boolean value
false
to disable the uploader and skip upload by default.Update ENV
VIDEO_LOCATION
->SE_VIDEO_FOLDER
to align with existing ENV present in video image selenium/video:ffmpeg-6.0Update in chart templates:
(.Values.videoRecorder.uploader | toString)
to work with case valueuploader: false
. Avoid Helm raise the error:at <.Values.videoRecorder.uploader>: wrong type for value; expected string; got bool
| quote
for.Values.videoRecorder.uploadDestinationPrefix
is able to to work with bool value inputTypes of changes
Checklist