chart: not patch KEDA objects if autoscaling disabled

Fix: #2268 Signed-off-by: Viet Nguyen Duc <[email protected]>
SeleniumHQ · Jun 21, 2024 · 904b8ea · 904b8ea
1 parent 2f0f249
commit 904b8ea
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/charts/selenium-grid/templates/patch-keda/patch-keda-objects-job.yaml b/charts/selenium-grid/templates/patch-keda/patch-keda-objects-job.yaml
@@ -1,4 +1,4 @@
-{{- if $.Values.autoscaling.patchObjectFinalizers.enabled }}
+{{- if and (eq (include "seleniumGrid.useKEDA" $) "true") $.Values.autoscaling.patchObjectFinalizers.enabled }}
 apiVersion: batch/v1
 kind: Job
 metadata:

diff --git a/...ts/selenium-grid/templates/rbac-role.yaml → ...-grid/templates/patch-keda/rbac-role.yaml b/...ts/selenium-grid/templates/rbac-role.yaml → ...-grid/templates/patch-keda/rbac-role.yaml
@@ -1,4 +1,4 @@
-{{- if $.Values.rbacRole.create }}
+{{- if and (eq (include "seleniumGrid.useKEDA" $) "true") $.Values.autoscaling.patchObjectFinalizers.enabled }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:

diff --git a/...nium-grid/templates/rbac-rolebinding.yaml → ...emplates/patch-keda/rbac-rolebinding.yaml b/...nium-grid/templates/rbac-rolebinding.yaml → ...emplates/patch-keda/rbac-rolebinding.yaml
@@ -1,4 +1,4 @@
-{{- if $.Values.rbacRoleBinding.create }}
+{{- if and (eq (include "seleniumGrid.useKEDA" $) "true") $.Values.autoscaling.patchObjectFinalizers.enabled }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:

diff --git a/charts/selenium-grid/values.yaml b/charts/selenium-grid/values.yaml
@@ -74,7 +74,6 @@ serviceAccount:
 
 # RBAC settings
 rbacRole:
-  create: true
   # nameOverride:
   annotations: {}
   rules:
@@ -95,7 +94,6 @@ rbacRole:
       verbs: [get, list, patch, update, delete]
 
 rbacRoleBinding:
-  create: true
   # nameOverride:
   annotations: {}
   roleRef: