docs: ✏️ Fix broken logo image in storybook (top left) #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken logo image in storybook (top left) ✅ Closes: #262
caleboleary
requested review from
20BBrown14,
codyarose and
SeanGroff
as code owners
|
From the docs:
So it's probably a good move not to commit that haha |
codyarose
approved these changes
May 21, 2021
SeanGroff
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken logo image in storybook (top left)
✅ Closes: #262
The below structure change seems to fix it, not sure why ¯_(ツ)_/¯
I did find some still open issues on storybook's github about theming cache issues, see storybookjs/storybook#13200
Adding the following seemed to clear it out and let me see the fixed logo. I didn't want to commit it since I don't really know what it might impact for a logo fix (low value) but something to try if you can't get theme changes to show in your local version.
