Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode binData before sending it to Predict function #993

Merged
merged 5 commits into from
Oct 25, 2019

Conversation

lennon310
Copy link
Contributor

@lennon310 lennon310 commented Oct 24, 2019

So the client won't need to implement decode in predict_raw by themselves.

Unit tests all passed.

Fixes #909

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gsunner

If they are not already assigned, you can assign the PR to them by writing /assign @gsunner in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Hi @lennon310. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@axsaucedo
Copy link
Contributor

/ok-to-test

python/seldon_core/wrapper.py Outdated Show resolved Hide resolved
@axsaucedo
Copy link
Contributor

@lennon310 if you remove .decode from your change it should be good to go.

We had a discussion and confirmed that the bytes may not always be expected to be string, so we would want to make it available as bytes for the user to receive it and use decode themselves.

python/seldon_core/flask_utils.py Outdated Show resolved Hide resolved
@axsaucedo
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

/approve

@ukclivecox
Copy link
Contributor

Thanks @lennon310 !

python/seldon_core/flask_utils.py Outdated Show resolved Hide resolved
@axsaucedo axsaucedo dismissed ukclivecox’s stale review October 25, 2019 15:54

already acccepted

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo merged commit f2d2aef into SeldonIO:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update python wrapper to pass bytes instead of string
4 participants